Minor refactorings for the Join class
#1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTF
commented
Oct 16, 2024
| Iterator it_; | ||
| [[no_unique_address]] const End end_; | ||
| const Projection& projection_; | ||
| CurrentBlocks currentBlocks_{}; | ||
|
|
||
| // Type aliases for a single element from a block from the left/right input. | ||
| using value_type = std::ranges::range_value_t<typename Iterator::value_type>; | ||
| using value_type = std::ranges::range_value_t<std::iter_value_t<Iterator>>; |
There was a problem hiding this comment.
This helper type also works if the iterator type is a pointer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
+ Coverage 88.93% 88.94% +0.01%
==========================================
Files 364 364
Lines 33127 33121 -6
Branches 3715 3714 -1
==========================================
- Hits 29462 29461 -1
+ Misses 2433 2431 -2
+ Partials 1232 1229 -3 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
Oct 18, 2024
Conformance check passed ✅No test result changes. |
|
joka921
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These include removing dead code and unused arguments, making functions
constor evenstatic, and applying similar minor non-functional refactorings.